fix: remove unnecessary search landmark nested in <search>#314
Merged
danielroe merged 2 commits intonpmx-dev:mainfrom Jan 29, 2026
Merged
fix: remove unnecessary search landmark nested in <search>#314danielroe merged 2 commits intonpmx-dev:mainfrom
search landmark nested in <search>#314danielroe merged 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Member
Author
|
This might need to be amended when/if #313 merges since it’s modifying the same bit of code. |
This comment was marked as outdated.
This comment was marked as outdated.
The `<search>` element’s implicit ARIA role is `search`, so setting `role=search` on the nested `<form>` is redundant and adds noise.
knowler
force-pushed
the
unnecessary-search-role
branch
from
d4dfade to
b288d5e
Compare
danielroe
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
<search>element’s implicit ARIA role issearch, so settingrole=searchon the nested<form>is redundant and adds noise (i.e. it will show up twice).If you want to increase support, then the role should be added to the
<search>element instead.